This is a really good point. So many people ask "Why would you want to do all this crazy prep stuff?" My question is, why wouldn't you? If any kind of disaster ever were to happen, you'd be much better off than most people out there. And if nothing ever does go wrong? Well, so what. As you said our preparations have given us something to do, and I think for most of us it is often things we enjoy doing anyway. We've most likely made our lives healthier and happier. There are so many benefits to being as prepared as you can for whatever may come, and if nothing horrific ever comes to pass, we've still been doing things we enjoy and improving our lives in the process. It's a win-win.
The only time I can see that it presents a problem is in this question: Do you have your preparations...or do your preparations have you? Those initiating preps in a knee jerk reaction to a failing economy by getting 3 chickens in the backyard that they cannot kill because they love them too much, have spent tons of money to have the chickens, trying to grow bits of food on postage stamp lawns in the suburbs and spending endless amounts of time on discussion, planning, supposing zombie apocalyptic situations and spending tons on special kinds of containers to store food but never actually producing enough food to warrant the money and time spent...well...there I can see a problem.
It may make one feel better but it doesn't really ever get them any closer to survival of the hard times to come....and rest assured, there are such hard times coming that stored food, food trees and a few chickens will not help.